Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cmake-preset): add configuration property for build presets #188

Merged
merged 1 commit into from
Aug 23, 2024
Merged

fix(cmake-preset): add configuration property for build presets #188

merged 1 commit into from
Aug 23, 2024

Conversation

sssooonnnggg
Copy link
Contributor

@sssooonnnggg sssooonnnggg commented Aug 23, 2024 •
edited
Loading

Add configuration property for buid presets, otherwise release build presets will also produce debug builds by default.
reference: https://cmake.org/cmake/help/latest/manual/cmake-presets.7.html

@sssooonnnggg
Copy link
Contributor Author

command line for testing: cmake --preset msvc_2022_relwithdebinfo && cmake --build --preset msvc_2022_relwithdebinfo

@syoyo syoyo merged commit f93caa5 into lighttransport:dev Aug 23, 2024
14 checks passed
@syoyo
Copy link
Collaborator

syoyo commented Aug 23, 2024

Thanks! merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sssooonnnggg @syoyo